Skip to content

Comments

⚒️ Migrate geo location search to compose#5864

Merged
AndyScherzinger merged 1 commit intomasterfrom
chore/noid/geoPickerCompose
Feb 17, 2026
Merged

⚒️ Migrate geo location search to compose#5864
AndyScherzinger merged 1 commit intomasterfrom
chore/noid/geoPickerCompose

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Feb 14, 2026 •
edited
Loading

  • Migrated to composables incl. previews for dark/light/rtl
  • Beware the migrated implementation respects the server colors (see blue vs. yellow shade (server color) in the screenshots below)

🖼️ Screenshots

🏚️ Before 🏡 After
before after

🚧 TODO

  • review & test

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Feb 14, 2026
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/geoPickerCompose branch 3 times, most recently from 4bc3900 to afae18a Compare February 14, 2026 14:11
@AndyScherzinger AndyScherzinger changed the title Migrate geo location search to compose ⚒️ Migrate geo location search to compose Feb 14, 2026
mahibi
mahibi requested changes Feb 16, 2026
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching in the results screen does not work at all. The whole searchterm remains visible when trying to delete chars with backspace.

Only the initial passed searchterm from the map view will show results.

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Feb 16, 2026

Didn't test that ... I'll have a look @mahibi 👍

@mahibi
Copy link
Collaborator

mahibi commented Feb 17, 2026

How i tested:

  1. in map view, type Paris and click on search
  2. in result view, try to delete paris
  3. type hamburg

paris cant be deleted

Screen_recording_20260217_093436.mp4

@AndyScherzinger AndyScherzinger force-pushed the chore/noid/geoPickerCompose branch 2 times, most recently from 75d82ad to 4826da0 Compare February 17, 2026 09:34
@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Feb 17, 2026

@mahibi rebased, fix amended and pushed:
search_location

The fix is
https://github.com/nextcloud/talk-android/pull/5864/changes#diff-b0cdc8e932b7d44dd3b140c3563097f3e840cdc99c0406e18a836eada2403ad6R63-R64

Other than that I replaced the query handling of just being a String to be a text field value to also ensure the cursor is initially put at the end, not at the beginning of the input field when opening the geo screen.

mahibi
mahibi approved these changes Feb 17, 2026
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine now 👍

just now i see that LiveData is used. In general we prefer to stick with Flows.
It's fine for this PR though.

Thank you Andy!

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Feb 17, 2026

just now i see that LiveData is used. In general we prefer to stick with Flows.

Ah, I thought we didn't use Flow but LiveData or might have confused it with Files 🙈

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Feb 17, 2026

@mahibi migrated via 0c960ce

feel free to re-review and merged if fine (I tested and all worked fine for me)

mahibi
mahibi approved these changes Feb 17, 2026
View reviewed changes
Elsensee
Elsensee reviewed Feb 17, 2026
View reviewed changes
@AndyScherzinger
chore: Migrate geo location search to compose
561d6c7 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/geoPickerCompose branch from 0c960ce to 561d6c7 Compare February 17, 2026 17:47
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5864.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@AndyScherzinger AndyScherzinger merged commit 279c1dd into master Feb 17, 2026
16 of 19 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/noid/geoPickerCompose branch February 17, 2026 18:50
AndyScherzinger added a commit that referenced this pull request Feb 18, 2026
@AndyScherzinger
chore: remove unused dependency
710c682 
formerly falsely introduced via #5864 but not completely removed when migrating from LiveData to Flows

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger mentioned this pull request Feb 18, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

@sowjanyakch sowjanyakch sowjanyakch approved these changes

+1 more reviewer

@Elsensee Elsensee Elsensee left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: chat 🗨️ technical debt Technical issue

Projects

None yet

Milestone

23.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AndyScherzinger @mahibi @Elsensee @sowjanyakch